ifad / carrierwave-colore

Carrier wave plugin for Colore
MIT License
0 stars 2 forks source link

Carrierwave cache storage #4

Open jonatasrancan opened 5 years ago

jonatasrancan commented 5 years ago

Since carrierwave 2.0.0rc if you don't specify which cache store to use, it will try to use the cache store implemented on the used storage. Before this the default options was to use file storage as default strategy for the cache.

carrierwave-colore doesn't implement the cache! method so we ended up getting some exceptions.

Need to implement #cache! if you want to use CarrierWave::Storage::Colore as a cache storage.

When this was introduced https://github.com/carrierwaveuploader/carrierwave/blob/master/CHANGELOG.md#changed

And the commit https://github.com/carrierwaveuploader/carrierwave/commit/629afecbaeccd2300e4660b78ee36bd95dd845c5#diff-a2fae088fb0c57593e3c4c6bd69bc382L189

Should carrierwave-colore handle cache as well or just fallback to file storage, like it was befere?