search

ifad / carrierwave-colore

Carrier wave plugin for Colore
MIT License
0 stars 2 forks source link

Change URI.escape with something else #5

Open tagliala opened 3 years ago

tagliala commented 3 years ago

https://github.com/ifad/carrierwave-colore/blob/3b3bdc7b285fcb43db711ef50c7613005db109ce/lib/carrierwave/storage/colore.rb#L80

https://github.com/ifad/carrierwave-colore/blob/3b3bdc7b285fcb43db711ef50c7613005db109ce/lib/carrierwave/storage/colore.rb#L83

https://github.com/ifad/carrierwave-colore/blob/3b3bdc7b285fcb43db711ef50c7613005db109ce/lib/carrierwave/storage/colore.rb#L144

~/.rvm/gems/ruby-2.7.2/bundler/gems/carrierwave-colore-3b3bdc7b285f/lib/carrierwave/storage/colore.rb:144: warning: URI.escape is obsolete
~/.rvm/gems/ruby-2.7.2/bundler/gems/carrierwave-colore-3b3bdc7b285f/lib/carrierwave/storage/colore.rb:144: warning: URI.escape is obsolete
.............................................~/.rvm/gems/ruby-2.7.2/bundler/gems/carrierwave-colore-3b3bdc7b285f/lib/carrierwave/storage/colore.rb:80: warning: URI.escape is obsolete
~/.rvm/gems/ruby-2.7.2/bundler/gems/carrierwave-colore-3b3bdc7b285f/lib/carrierwave/storage/colore.rb:83: warning: URI.escape is obsolete
tagliala commented 3 years ago

We can add addressable as a runtime dependency and use Addressable::URI.encode_component(url)