ifad / data-confirm-modal

Makes Rails' link_to confirm: 'foo' build a Bootstrap Modal instead of calling the browser's confirm() API.
MIT License
270 stars 115 forks source link

"form-control" as default for verifyClass #32

Closed jdugarte closed 9 years ago

jdugarte commented 9 years ago

First of all: thanks for this gem! I was about to build something similar when I found it 😁

I was wondering: why isn't "form-control" set as default for verifyClass, being this a bootstrap styled gem? I know I can set it like this:

dataConfirmModal.setDefaults({ verifyClass: 'form-control', });

but I would have thought this to be the default already, again, being this a bootstrap styled gem.

I was going to do a pull request with this, but I thought I ask first, in case there is something I'm missing here.

Thanks,

Jesús.-

vjt commented 9 years ago

That makes perfect sense. Done, thank you.

jdugarte commented 9 years ago

@vjt Thanks! 😁