search

ifad / data-confirm-modal

Makes Rails' link_to confirm: 'foo' build a Bootstrap Modal instead of calling the browser's confirm() API.
MIT License
270 stars 115 forks source link

Add bower.json #49

Closed dapicester closed 7 years ago

dapicester commented 7 years ago

I added a minimal bower.json so that one can include this in other projects, also non-Rails projects (I am currently using it in a Django project where I manage my front-end packages with Bower).

vjt commented 7 years ago

Thanks! Shouldn't we also add a bootstrap dependency? Then, out of curiosity, are you using jquery-ujs in your Django project?

Thanks again

dapicester commented 7 years ago

Yes, I am using jquery-ujs (I miss Rails...) You're also right about bootstrap dependency, I'll try to put that in and test. If it works I'll submit another PR.

However, even the Bower website suggests to switch to yarn, which is supported in Rails 5.1. If I will ever make the switch I'll try to add a simple package.json too.

Thanks for merging!

dapicester commented 7 years ago

I added dependency to bootstrap and fixed the versions.

vjt commented 7 years ago

Thanks!