Rails 5.1 support - Githubissues

ifad / data-confirm-modal

Makes Rails' link_to confirm: 'foo' build a Bootstrap Modal instead of calling the browser's confirm() API.

MIT License

270 stars 115 forks source link

Rails 5.1 support #55

Closed CyberDeck closed 7 years ago

CyberDeck commented 7 years ago

Hi there, just some small changes to get it working with Rails 5.1 (and some changes in the modal-dialog to reflect Bootstrap 4.0.0.beta layout). As long as rails/rails#29965 is not accepted, one need to overwrite "window.confirm" instead of "Rails.confirm".

What is your opinion?

vjt commented 7 years ago

Hi, thanks for this. Are the changes backwards-compatible? If yes, I will merge this gladly. If not, I'll create a new branch and update the README accordingly.

Sorry for the delay!

vjt commented 7 years ago

I answer myself - yes this is backwards-compatible and it works well. Thank you @CyberDeck!

CyberDeck commented 7 years ago

Thank you!

archonic commented 7 years ago

@vjt Could 1.5 be shipped to NPM? Please and thank you :)

vjt commented 7 years ago

yes, sure, doing it.

vjt commented 7 years ago

@archonic published.