search

ifad / data-confirm-modal

Makes Rails' link_to confirm: 'foo' build a Bootstrap Modal instead of calling the browser's confirm() API.
MIT License
271 stars 115 forks source link

Bootstrap 4 support? #56

Closed rkbhochalya closed 6 years ago

rkbhochalya commented 6 years ago

I tried to use it with Rails 5.1 and Bootstrap 4 but the default alert messages is showing instead of the modal. There are no JS errors in the console. Do you have any plan to support Bootstrap 4 and Rails 5?

CyberDeck commented 6 years ago

You can try out my pull request #55. Please share your opinions on it. So far no update from official maintainer.

vjt commented 6 years ago

Fixed in #55. Thanks everyone!

archonic commented 6 years ago

I'm not seeing support for BS4. The modalClass argument ends up colouring the whole background and the title is on the right. Is BS4 support in the roadmap?

limestone

It would be nice to have a template override for the HTML of the modal so we could spin our own support and make any mods we want.

Update: I spoke too soon. Updating to 1.5 through NPM has fixed the title issue. modalClass is still applying that class to the outermost div instead of the dialog, but I believe that's intentional. I can work with that.