search

ifad / data-confirm-modal

Makes Rails' link_to confirm: 'foo' build a Bootstrap Modal instead of calling the browser's confirm() API.
MIT License
271 stars 115 forks source link

v1.5.0 break Bootstrap 3 modals #59

Closed Varek closed 6 years ago

Varek commented 6 years ago

Hi, thanks for this gem, it made replacing confirm alerts with modals a breeze.

The latest version brought Rails 5 and Bootstrap 4 support. In the pull #55 you where wondering about the backward compatibility and said that everything is fine. But I noticed the Bootstrap 4 modal change break the Bootstrap 3 modals. v1.5.0 with Bootstrap 3 looks like this: Broken Bootstrap 3 modal Here a jsfiddle(your example with the latest version) to demonstrate: http://jsfiddle.net/ze2Lz8tm/56/

Downgrading solved it for me, but maybe you should create a Bootstrap 3 compatible version and add a notice in the readme.

vjt commented 6 years ago

Thanks for the report. I will look into this. Sorry for the inconvenience.

vjt commented 6 years ago

Hi,

issue fixed and new version released as 1.6.0.

Cheers,