search

ifad / data-confirm-modal

Makes Rails' link_to confirm: 'foo' build a Bootstrap Modal instead of calling the browser's confirm() API.
MIT License
270 stars 115 forks source link

Does it work with rails 5.1 and Bootstrap 4? #63

Closed ketysek closed 6 years ago

ketysek commented 6 years ago

Hi, I've installed your library, then I've pasted it in application.js

//= require jquery3 //= require popper //= require bootstrap //= require data-confirm-modal

but it doesn't work. Every time I'm getting old, browser window just like without using your lib. Console is clear, without errors.

mgrubb commented 6 years ago

same here

vjt commented 6 years ago

Will check this out asap.

mgrubb commented 6 years ago

The latest HEAD from github works, but the Gem release (1.6.1) doesn't. I'm guessing it's because the fix for issue #61 isn't included in that release.

vjt commented 6 years ago

Thanks for the feedback. I will cut a new release today.

~Marcello -- ~ vjt@openssl.it ~ http://sindro.me/

On 10 Mar 2018, at 05:48, Michael Grubb notifications@github.com wrote:

The latest HEAD from github works, but the Gem release (1.6.1) doesn't. I'm guessing it's because the fix for issue #61 isn't included in that release.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

vjt commented 6 years ago

Released v1.6.2 on RubyGems and npm.

Please reopen if you still encounter issues.

Thanks!