search

ifad / data-confirm-modal

Makes Rails' link_to confirm: 'foo' build a Bootstrap Modal instead of calling the browser's confirm() API.
MIT License
271 stars 115 forks source link

MODAL: Option "backdrop" provided type "undefined" #64

Open archonic opened 6 years ago

archonic commented 6 years ago

I'm getting this with bootstrap 4:

MODAL: Option "backdrop" provided type "undefined" but expected type "(boolean|string)"

The link is just 

link_to 'Cancel account', registration_path(resource_name), method: :delete, class: 'btn btn-danger', data: { confirm: 'Are you sure?' }

I'm thinking the version of BS 4 I'm running changed the argument requirements. Looking at data-confirm-modal.js, it looks like it plugs the data attributes directly into the BS modal function without conferring with defaults. Should backdrop, keyboard and show be using ||= instead?

camilleroux commented 6 years ago

Same error here. Can I help giving you more information?

archonic commented 6 years ago

Because this gem basically just wraps one JS file, I took out that file, modified it for only supporting BS4, converted it to coffee and fixed the error seen here.

Here's the gist. https://gist.github.com/archonic/8a9392a005d0bc1ab621c69619825afe

I'll leave the issue open because I think this gem is broken out of the box for bootstrap 4 post-release.