Remove/Change methods which are deprecated by jQuery3

ifad / data-confirm-modal

Makes Rails' link_to confirm: 'foo' build a Bootstrap Modal instead of calling the browser's confirm() API.

MIT License

271 stars 115 forks source link

Remove/Change methods which are deprecated by jQuery3 #87

Closed timokae closed 3 years ago

timokae commented 3 years ago

This pull request removes the methods focus (in v3.3.0) and delegate (in v3.0.0) got deprecated.

In case of focus the underlying trigger method is used, which is available since v1.0.0. For the delegate method, on is being used instead (added in v1.7.0).

tagliala commented 3 years ago

Hi @timokae, thanks for this PR

Is this change backward compatible with jQuery 1.12? I've tried in a fiddle and it looks it is

timokae commented 3 years ago

I just updated my text above. It should be. I added the methods on (added in 1.7) and trigger (added in 1.0). Both are already available in 1.12.

tagliala commented 3 years ago

@timokae could you please rebase from master?

Please also edit the commit message with

This pull request removes the methods focus (in v3.3.0) and delegate
(in v3.0.0) got deprecated.

In case of focus the underlying trigger method is used, which is
available since v1.0.0. For the delegate method, on is being used
instead (added in v1.7.0).

tagliala commented 3 years ago

Tested against Rails4/BS3/jQuery1.12 and Rails6/BS4/jQuery3

Thanks