ifahrentholz / eds-editorial

Apache License 2.0
4 stars 2 forks source link

Lcp block bug fix #87

Closed LoomingEcho closed 5 months ago

LoomingEcho commented 6 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Test URLs:

This Branch fixes the render problem of LCP blocks from the main.ts refactoring

aem-code-sync[bot] commented 6 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [5c8e46c](https://github.com/ifahrentholz/eds-editorial/commit/5c8e46c8cc435f77b7d683e6274f5f8d4770df3b) :white_check_mark: (latest) * [feb4af6](https://github.com/ifahrentholz/eds-editorial/commit/feb4af60ba988bf9d8aa57594ccdfa73c4c4c1a7) :white_check_mark: * [5489f9e](https://github.com/ifahrentholz/eds-editorial/commit/5489f9e64a3dd132d1175a399ff399483db6ae93) :white_check_mark: * [4071159](https://github.com/ifahrentholz/eds-editorial/commit/407115923c88dd797163612276989c00dd8bc990) :white_check_mark: * [9f4aa95](https://github.com/ifahrentholz/eds-editorial/commit/9f4aa9506189debafb9fb92ffe163b869a6566d8) :white_check_mark: * [7d74a6f](https://github.com/ifahrentholz/eds-editorial/commit/7d74a6f62e0431c17c056e7ce9ec985117e9c6c8) :white_check_mark: * [3c53554](https://github.com/ifahrentholz/eds-editorial/commit/3c5355472e69fba79b0bb63512bdc90767d690ed) :white_check_mark: * [ca9373c](https://github.com/ifahrentholz/eds-editorial/commit/ca9373cdca85cbfd0d63f1b1b43c00c6932f5e46) :white_check_mark: * [23e3054](https://github.com/ifahrentholz/eds-editorial/commit/23e305414454d6d1779fd0a5e9e5a5ae3ada384e) :white_check_mark: * [7c37fa7](https://github.com/ifahrentholz/eds-editorial/commit/7c37fa749dbc16b620698576c96ad14dbb9928c0) :white_check_mark: * [4b9801b](https://github.com/ifahrentholz/eds-editorial/commit/4b9801b57f73f7149d05366f72520eca1afa61b9) :white_check_mark: * [c598513](https://github.com/ifahrentholz/eds-editorial/commit/c59851338c5ff38f47659129eae2a1f54aff6082) :white_check_mark: * [cfeb7c9](https://github.com/ifahrentholz/eds-editorial/commit/cfeb7c90363b5de215bb1b6533277a75b6768a33) :white_check_mark: * [4d894cf](https://github.com/ifahrentholz/eds-editorial/commit/4d894cfcc1cfc1fc8384348f82d5e68b99ea1670) :white_check_mark: * [cc80839](https://github.com/ifahrentholz/eds-editorial/commit/cc80839ecc334fb44561b0173f0e174bd60d8b31) :white_check_mark: * [88fe755](https://github.com/ifahrentholz/eds-editorial/commit/88fe755e8025634472d496221ab02f040b4003df) :white_check_mark: * [44dee46](https://github.com/ifahrentholz/eds-editorial/commit/44dee463d3657b1719b1611767d0a13789788d8b) :white_check_mark: * [c53796d](https://github.com/ifahrentholz/eds-editorial/commit/c53796d8ff7bec35dcb7c97abbdf1032a06fd017) :white_check_mark: * [74e8300](https://github.com/ifahrentholz/eds-editorial/commit/74e83009b43ab4cbf1f1c7977b9946a30edda77c) :white_check_mark: * [7b008f4](https://github.com/ifahrentholz/eds-editorial/commit/7b008f4415609ae2cc4d2259280557d23838171d) :white_check_mark: * [ace90e3](https://github.com/ifahrentholz/eds-editorial/commit/ace90e364f75daa415b73e1f0c54fc28565227e6) :white_check_mark: * [5876593](https://github.com/ifahrentholz/eds-editorial/commit/58765934f2a1a3ad30358d611ac1330cee37598f) :white_check_mark: * [803f767](https://github.com/ifahrentholz/eds-editorial/commit/803f767b13cdc7a1e6d8fbbc80930932d0b645e2) :white_check_mark: * [9f290ca](https://github.com/ifahrentholz/eds-editorial/commit/9f290cace689f111dca7eb98bf5fb1d53f5f8a40) :white_check_mark: * [033c9d4](https://github.com/ifahrentholz/eds-editorial/commit/033c9d494bdd0eb747b12b9cdf6928c4620c4e3a) :white_check_mark: * [dc6fa0c](https://github.com/ifahrentholz/eds-editorial/commit/dc6fa0c680d4b8ed785fb012cb5987163d184a7f) :white_check_mark: * [49002e0](https://github.com/ifahrentholz/eds-editorial/commit/49002e0f428016cf5635baa2a997263349c99d32) :white_check_mark: * [a4f6d63](https://github.com/ifahrentholz/eds-editorial/commit/a4f6d63919835063f50e7af95cca0e7f9a138579) :white_check_mark: * [af5eabf](https://github.com/ifahrentholz/eds-editorial/commit/af5eabf671bee35a4a0839b5f9059682d970a177) :white_check_mark: * [c5c7310](https://github.com/ifahrentholz/eds-editorial/commit/c5c7310d4ca0cd0fd7f101e3dba9c9146f0ef251) :white_check_mark:
aem-code-sync[bot] commented 6 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
LoomingEcho commented 6 months ago

This MR needs first to be merged

https://github.com/ifahrentholz/eds-editorial/pull/83