search

ifandelse / machina.js

js ex machina - finite state machines in JavaScript
http://machina-js.org/
Other
1.93k stars 147 forks source link

Clean a few variables and change fsm.js file to Fsm.js #89

Closed igncp closed 9 years ago

igncp commented 9 years ago

Hi there,

I was reviewing the code of this great project (examples, src, tests) and saw some possible minor changes. The most important was to add var to a non defined variable (action), as when running fsm1.handle(), it was added to the global scope (e.g. window). I also removed some variables that were not used anymore.

Furthermore, renamed the fsm.js file to Fsm.js as it was failing when doing npm run build, it was that or changing the //import line (but I saw this was also done in a pending PR).

ifandelse commented 9 years ago

@igncp I apologize that I've left this PR sitting for so long! I was in the middle of some other changes at the time (if I recall correctly) and had already diverged a bit. However I did incorporate your suggestions and am going to add you to the contributors list in the package.json with the next version bump. Really appreciate you taking time to contribute!