search

ifarup / ciefunctions

Python module, GUI, and web app for computing the CIE TC1-97 colorimetric functions
GNU General Public License v3.0
4 stars 5 forks source link

Will this be renamed to lms_mw eventually? or will it stay as it is? (what's correct?) #187

Closed gerardodiego closed 4 years ago

gerardodiego commented 5 years ago

https://github.com/ifarup/ciefunctions/blob/b14d120cfa7fb6474419af04ff3f37b2bb22d616/tc1_97/plot.py#L228

janhenrikwold commented 5 years ago

The naming rule (template) I introduced/used in the naming of the function plots was that functions plotting two dimensional chromaticity diagrams should be named by the two coordinate symbols (that is, the abscissa symbol followed by the ordinate symbol, for instance 'ls' and 'lm') followed by underscore and an abbreviation for the type of diagram (for instance '_mb' for Boynton-MacLeod, and '_mw' for Maxwellian. Thus 'lm_mw' names a Maxwellian lm diagram and 'ls_mb' names a MacLeod-Boynton ls diagram. When Ivar changed the name of the function plotting the MacLeod-Boynton ls diagrams from ls_mb into lms_mb, the name no longer accord with this naming rule.

In my opinion I would therefore prefer to go back to the name 'ls_mb' for this function, and, accordingly, keep the name 'lm_mw' in case of the function plotting the Maxwellian lm diagrams.

(In the naming rules that I have introduced/used all through the program/code, names like 'lms_mb' and 'lms_mw' are names for lists of all three chromaticity coordinates (also the one not shown in the associated chromaticity diagram. Thus I fear the renaming made by Ivar from 'lm_mb' to 'lms_mb' might appear as somewhat confusing.)

ifarup commented 5 years ago

Det er allerede reversert. Endringen var basert på en misforståelse.

  1. des. 2018 17:37 skrev Jan Henrik Wold notifications@github.com:

The naming rule (template) I introduced/used in the naming of the function plots was that functions plotting two dimensional chromaticity diagrams should be named by the two coordinate symbols (that is, the abscissa symbol followed by the ordinate symbol, for instance 'ls' and 'lm') followed by underscore and an abbreviation for the type of diagram (for instance '_mb' for Boynton-MacLeod, and '_mw' for Maxwellian. Thus 'lm_mw' names a Maxwellian lm diagram and 'ls_mb' names a MacLeod-Boynton ls diagram. When Ivar changed the name of the function plotting the MacLeod-Boynton ls diagrams from ls_mb into lms_mb, the name no longer accord with this naming rule.

In my opinion I would therefore prefer to go back to the name 'ls_mb' for this function, and, accordingly, keep the name 'lm_mw' in case of the function plotting the Maxwellian lm diagrams.

(In the naming rules that I have introduced/used all through the program/code, names like 'lms_mb' and 'lms_mw' are names for lists of all three chromaticity coordinates (also the one not shown in the associated chromaticity diagram. Thus I fear the renaming made by Ivar from lm_mb to lms_mb might appear as somewhat confusing.)

- You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ifarup/ciefunctions/issues/187#issuecomment-447910446, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFVeCrD5A8bp-vq_eE3fERSa-tSM1Xjlks5u58hSgaJpZM4ZWhqY.

janhenrikwold commented 5 years ago

Javel, da var fornemmelsen av engstelse altså helt ubegrunnet. (Da senker jeg skuldrene og tar meg et glass).

gerardodiego commented 5 years ago

Eller to ;)

Jeg fortsetter og koder :)

On Mon, 17 Dec 2018 at 17:46 Jan Henrik Wold notifications@github.com wrote:

Javel, da var fornemmelsen av engstelse altså helt ubegrunnet. (Da senker jeg skuldrene og tar meg et glass).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ifarup/ciefunctions/issues/187#issuecomment-447913710, or mute the thread https://github.com/notifications/unsubscribe-auth/AD7NwTyJHpNWPmFcemCqqqvOzEgau-hxks5u58phgaJpZM4ZWhqY .