Can't retrieve crate keys from crates that have a name with uppercase characters

AndreasHGK commented 5 years ago

Reproduce:

make a new crate with an uppercase name in crates.yml
start the server, place the crate and restart the server
do /keyall or /key with the correct name with or without uppercase
it doesn't work. It says that the crate doesn't exist.

Pluign version: v9.1.0 Pocketmine version: 3.7.1

This happens because you first make the name lowercase in both commands: https://github.com/JackMD/MysteryCrate/blob/a4402559c655cf6a656146573ce1064d19db8876/src/JackMD/MysteryCrate/command/KeyAllCommand.php#L73 After that, you compare the name to a possibly uppercase crate in crates.yml https://github.com/JackMD/MysteryCrate/blob/a4402559c655cf6a656146573ce1064d19db8876/src/JackMD/MysteryCrate/Main.php#L319

Ifera commented 5 years ago

Yes I am aware of this bug for quite some time now but I haven't had the time to fix it.

Ifera commented 5 years ago

I mean I know how to fix this but the reality is I have lost motivation working on this plugin.. In its current form this is one giant piece of 💩... And I cba to fix it...

Ifera commented 5 years ago

Didnt meant to close...

AndreasHGK commented 5 years ago

sounds familiar

Ifera commented 5 years ago

yep

Ifera commented 4 years ago

Eh closing in favor of archiving. And i have no plans on maintaining this.

ifera-mc / MysteryCrate

Can't retrieve crate keys from crates that have a name with uppercase characters #120