search

iffy / install-nim

Github Action to install Nim
MIT License
30 stars 1 forks source link

missing releases of v4.3.0, v4.3.1, and v4.4.0 #29

Closed ee7 closed 1 year ago

ee7 commented 1 year ago

In the Marketplace, the Action's latest version is v4.2.0, which corresponds to the latest release.

However, the latest tag is v4.3.1, and from https://github.com/iffy/install-nim/commit/531d17139d73db5c731e9937b48769d905c6a40f it seems like the intention was to tag v4.4.0 too?

Is it intended that users shouldn't get the goodness of https://github.com/iffy/install-nim/compare/v4.2.0...531d17139d73db5c731e9937b48769d905c6a40f yet?

Previously: https://github.com/iffy/install-nim/issues/22

iffy commented 1 year ago

I'll be honest: I don't understand how the marketplace works :) I guess I have to make a GitHub Release every time to get it out there?

I've finally create a v4 branch so you don't have to change the version in your workflows every time. Maybe I can get the Marketplace to display that.

iffy commented 1 year ago

Okay, published!

ee7 commented 1 year ago

I guess I have to make a GitHub Release every time to get it out there?

I think so, yes.

I've finally create a v4 branch so you don't have to change the version in your workflows every time.

I believe that a v4 branch isn't required in order for uses: iffy/install-nim@v4 to work.

But pinning the SHA of an action is best practice for reliability and security anyway (see e.g. https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions), so I don't personally pin versions like @v4.

ee7 commented 1 year ago

Okay, published!

Thanks!

I guess I have to make a GitHub Release every time to get it out there?

If you wanted to automate it, you could add a workflow that's triggered by pushing a tag to master, which then creates the release by running something like gh release create:

gh release create --draft --generate notes

or some equivalent command to hit the GitHub API.

ee7 commented 1 year ago

I don't mind at all, but just in case it isn't intended: there's still no release for v4.3.0 and v4.3.1.

As always, thanks again for your work in this repo. And for the super fast reply and release. Much appreciated.

iffy commented 1 year ago

If you wanted to automate it

I think I eventually will :) Thanks for pinging me about this.

there's still no release for v4.3.0 and v4.3.1

Does that mean you can't use those versions? Or does it just mean they don't show up in the marketplace?

ee7 commented 1 year ago

Thanks for pinging me about this.

No problem.

Does that mean you can't use those versions?

I've checked, and it turns out that a workflow with uses: iffy/install-nim@v4.3.0 worked even though there's no v4.3.0 release and it doesn't appear on the marketplace.

I don't know: