iffy / wiish

Why Is It So Hard (to make a cross-platform app)?
MIT License
116 stars 7 forks source link

Build Fail - Possible Use Of Deprecated #69

Closed bitnom closed 3 years ago

bitnom commented 3 years ago

It's been a while so thought I would check in to see how wiish is doing. tried to install from master. Ubuntu 18.04 amd64

Got:

  Executing "/home/user/.nimble/bin/nim" c --noNimblePath -d:NimblePkgVersion=0.1.0 -d:release --path:"/home/user/.nimble/pkgs/parsetoml-0.5.0"  --path:"/home/user/.nimble/pkgs/argparse-1.1.0"  --path:"/home/user/.nimble/pkgs/jnim-0.5.1"  --path:"/home/user/.nimble/pkgs/opengl-1.2.6"  --path:"/home/user/.nimble/pkgs/x11-1.1"  --path:"/home/user/.nimble/pkgs/webview-0.1.0"  --path:"/home/user/.nimble/pkgs/sdl2_nim-#master"  --path:"/home/user/.nimble/pkgs/darwin-0.1.0"  -o:"/tmp/nimble_26175/githubcom_iffywiishgit/wiish" "/tmp/nimble_26175/githubcom_iffywiishgit/wiish.nim"
     Error: Build failed for package: wiish
        ... Details:
        ... Execution failed with exit code 1
        ... Command: "/home/user/.nimble/bin/nim" c --noNimblePath -d:NimblePkgVersion=0.1.0 -d:release --path:"/home/user/.nimble/pkgs/parsetoml-0.5.0"  --path:"/home/user/.nimble/pkgs/argparse-1.1.0"  --path:"/home/user/.nimble/pkgs/jnim-0.5.1"  --path:"/home/user/.nimble/pkgs/opengl-1.2.6"  --path:"/home/user/.nimble/pkgs/x11-1.1"  --path:"/home/user/.nimble/pkgs/webview-0.1.0"  --path:"/home/user/.nimble/pkgs/sdl2_nim-#master"  --path:"/home/user/.nimble/pkgs/darwin-0.1.0"  -o:"/tmp/nimble_26175/githubcom_iffywiishgit/wiish" "/tmp/nimble_26175/githubcom_iffywiishgit/wiish.nim"
        ... Output: Hint: used config file '/home/user/.nimble/config/nim.cfg' [Conf]
        ... Hint: used config file '/home/user/.nimble/config/config.nims' [Conf]
        ... Hint: used config file '/tmp/nimble_26175/githubcom_iffywiishgit/nim.cfg' [Conf]
        ... .......................
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiish.nim(8, 8) Warning: import os.nim instead; ospaths is deprecated [Deprecated]
        ... ................
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/buildutil.nim(62, 13) Warning: use dirExists; existsDir is deprecated [Deprecated]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_macos.nim(4, 8) Warning: imported and not used: 'parsetoml' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_macos.nim(2, 8) Warning: imported and not used: 'osproc' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_macos.nim(5, 8) Warning: imported and not used: 'posix' [UnusedImport]
        ... .......
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_ios.nim(389, 7) Hint: 'childPid' is declared but not used [XDeclaredButNotUsed]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_ios.nim(399, 7) Hint: 'cap' is declared but not used [XDeclaredButNotUsed]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_ios.nim(8, 8) Warning: imported and not used: 'posix' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_ios.nim(13, 8) Warning: imported and not used: 'xmlparser' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_ios.nim(11, 8) Warning: imported and not used: 'sequtils' [UnusedImport]
        ... .
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_windows.nim(3, 8) Warning: import os.nim instead; ospaths is deprecated [Deprecated]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_windows.nim(1, 8) Warning: imported and not used: 'os' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_windows.nim(2, 8) Warning: imported and not used: 'osproc' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_windows.nim(5, 8) Warning: imported and not used: 'parsetoml' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_windows.nim(4, 8) Warning: imported and not used: 'strformat' [UnusedImport]
        ... .
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_linux.nim(1, 8) Warning: imported and not used: 'os' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_linux.nim(2, 8) Warning: imported and not used: 'osproc' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_linux.nim(3, 8) Warning: imported and not used: 'strformat' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_linux.nim(4, 8) Warning: imported and not used: 'posix' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_linux.nim(5, 8) Warning: imported and not used: 'parsetoml' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_linux.nim(8, 8) Warning: imported and not used: 'buildutil' [UnusedImport]
        ... .
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_android.nim(53, 23) Warning: use dirExists; existsDir is deprecated [Deprecated]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_android.nim(75, 23) Warning: use dirExists; existsDir is deprecated [Deprecated]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_android.nim(275, 9) Hint: 'p' is declared but not used [XDeclaredButNotUsed]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build_android.nim(8, 8) Warning: imported and not used: 'posix' [UnusedImport]
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/build.nim(2, 8) Warning: imported and not used: 'osproc' [UnusedImport]
        ... ....
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiishpkg/building/doctor.nim(1, 8) Warning: imported and not used: 'os' [UnusedImport]
        ... ......
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiish.nim(29, 18) template/generic instantiation of `newParser` from here
        ... /tmp/nimble_26175/githubcom_iffywiishgit/wiish.nim(32, 8) Error: type mismatch: got <string, default: string>
        ... but expected one of: 
        ... proc arg(varname: string; default = none(); env = ""; help = ""; nargs = 1)
        ...   first type mismatch at position: 2
        ...   required type for default: Option[system.string]
        ...   but expression 'default = "."' is of type: string
        ... expression: arg("directory", default = ".")
iffy commented 3 years ago

Thanks for checking in! Wiish is currently undergoing some heavy renovation :) If you want you can take a look at the web-dev and build-plugins branches, but I expect those won't install either right now. I'm hoping to get the current work merged into master with all builds passing in the next few weeks.

This error in particular is happening because of a breaking change in a new version of argparse: https://github.com/iffy/nim-argparse/blob/master/CHANGELOG.md#v100---2020-11-26

bubthegreat commented 3 years ago

I opened a PR to pin the argparse version for the short term until the overhaul is complete: https://github.com/iffy/wiish/pull/73. Also relevant - if you're getting an error with the pcre64.dll, you can check out this guy: https://github.com/nim-lang/nightlies/issues/10

After downloading the pcre64, rebuilding, and using the pinned version of argparse, I was able to get a test project running on windows 10:

image

bitnom commented 3 years ago

I opened a PR to pin the argparse version for the short term until the overhaul is complete: #73. Also relevant - if you're getting an error with the pcre64.dll, you can check out this guy: nim-lang/nightlies#10

After downloading the pcre64, rebuilding, and using the pinned version of argparse, I was able to get a test project running on windows 10:

Give me Linux or give me death. Thanks though I'll try some more based on replies.

iffy commented 3 years ago

I made changes in the latest master branch so that it doesn't require pcre anymore. But maybe I missed some spots -- so let me know if you're still getting errors related to that.

iffy commented 3 years ago

I think this is fixed, so I'm closing. Please reopen if that's not the case.