Closed zihaohe123 closed 6 years ago
Presence looks fine for the options, but does not need to also be used for the client/server/relay functions.
From the YANG doctor's review, the intention around using features for the options was to do this per-option rather than at the device function level. In this pull request, if-feature at the element function level will mean that when the options are referenced in the device state tree, they will not be useable.
e.g. Client has feature 'client_op', but not 'server_op'. The server-option-definitions are reference as config false in the client model, but as server_op feature is not enabled, they aren't useable.
Thanks. There are indeed some problems using features at the device function level. So, does this mean that we need to add a 'feature' for each option? That seems not so extensible.
Hi, I re-used 'feature' for each option. Besides the six issues you mentioned a few days ago, I'll focus on the modeling of options where many problems exist.
Hi, that looks better. I don't really see any scalability problems with this - if the option is supported the feature can be enabled. This also allows the ability for a devices option support to be discovered when the initial netconf capabilities exchange takes place which is useful. In the versions you've submitted, there's some yang compilation problems - seems to be inconsistent naming in the features and when they are called: pyang -f tree ietf-dhcpv6-options\@2017-11-24.yang ietf-dhcpv6-options@2017-11-24.yang:262: error: feature "dns-config-op" not found in module ietf-dhcpv6-options ietf-dhcpv6-options@2017-11-24.yang:284: error: feature "dns-searchlist-op" not found in module ietf-dhcpv6-options ietf-dhcpv6-options@2017-11-24.yang:401: error: feature "info-refresh-op" not found in module ietf-dhcpv6-options ietf-dhcpv6-options@2017-11-24.yang:447: error: feature "tzbd-timezone-op" not found in module ietf-dhcpv6-options ietf-dhcpv6-options@2017-11-24.yang:535: error: feature "aftr-name-op" not found in module ietf-dhcpv6-options ietf-dhcpv6-options@2017-11-24.yang:679: error: feature "pcp-server-op" not found in module ietf-dhcpv6-options ietf-dhcpv6-options@2017-11-24.yang:921: error: feature "rapid-commmit-op" not found in module ietf-dhcpv6-options
Hi, here are the changes in this version: