search

ifiokjr / gatsby-plugin-next-seo

Gatsby Plugin Next SEO is a plug in that makes managing your SEO easier in Gatsby projects.
MIT License
196 stars 20 forks source link

License is missing copyright notice #20

Closed ghost closed 3 years ago

ghost commented 4 years ago

A condition of the MIT license is that the license text and the copyright notice must remain in derrivative copies. You should restore Gary's name since it looks like it was removed in https://github.com/ifiokjr/gatsby-plugin-next-seo/commit/094d3162bf07bfda338df708bea72d18cc993471

ifiokjr commented 4 years ago

@garmeeh what are your thoughts?

ifiokjr commented 3 years ago

Closing, please comment if you think this is premature.

ghost commented 3 years ago

Please correct me if I'm wrong. But if I'm not mistaken this commit changed the copyright holder. Then the copyright holder was omitted entirely later. In order to square up your license you need to restore the original copyright notice and then add a copyright notice of your own. Without that it's not clear this may be an adapted work and, assuming it is, who the copyright holder(s) are.

ifiokjr commented 3 years ago

Feel free to open a PR, I'll happily merge it.

ghost commented 3 years ago

Feel free to open a PR, I'll happily merge it.

I'm offering guidance to the maintainer. I hope it has been helpful. It's not my place to make license changes to software projects I've not been an active contributor to. But one thing is certain and that's that this software needs a proper license in order to be most useful to the community. How you choose to handle that as at your discretion. Thanks for your ear.

ifiokjr commented 3 years ago

Okay when you have time, I'll merge your work.

ghost commented 3 years ago

Okay when you have time, I'll merge your work.

I think you may have misunderstood my message. I will not be submitting any fixes. I've given guidance. The code is still wrong. Please let me know if anything is unclear.