search

ifl0w / RandomWallpaperGnome3

Random Wallpapers for Gnome 3
MIT License
178 stars 42 forks source link

Add ratio filter #159

Closed albertyablonskyi closed 9 months ago

albertyablonskyi commented 1 year ago

Hi there, so basically this PR replaces filtering with resolutions on ratios and minimum width/height filtering for Wallhaven. The goal is to improve the quality of image request, because with strict filtering by resolutions, it's often happens that Wallhaven has an image that fits the keywords, but does not have an image that matches the exact resolutions specified by users, which limits the variety of wallpapers. Now it is possible to filter images using proportions, and to specify the resolution (quality) of the image by giving the minimum height and width of the image, making it easier for users to specify images without incorrect limiting. image

ifl0w commented 1 year ago

This is a great idea, and I didn't know that Wallhaven supports this option! Optimally the user can select either your implementation or the exact resolution. Nevertheless, I think the "at least" option should become the default!

Now to the bad: Maybe you already saw that there are a lot of open PRs. So I'd rather like to include this change in the next iteration of the extension. Then this PR would remain open until the other stuff is closed and we have the new UI. Are you fine with this?

Lucki commented 1 year ago

Already did that: 55eb40d (#154)

(But also replaced the fixed resolutions)

ifl0w commented 9 months ago

Closing this as it should be implemented in v3.0.0.