search

ifl0w / RandomWallpaperGnome3

Random Wallpapers for Gnome 3
MIT License
176 stars 40 forks source link

Single preview widget for all history elements #187

Closed ifl0w closed 4 months ago

ifl0w commented 5 months ago

Change how images are previewed in the popup menu.

Screenshot

ifl0w commented 5 months ago

@Lucki I'd like to get this change into v3 because how I used to preview the images was not good IMO. What do you think of this?

Lucki commented 5 months ago

Looks good!

Without the separating image the drop-down looks a bit awkward tho: grafik

Not sure if the removal of the live preview in the background is intentional but I think it's not?

Also: somewhere there's logic to revert the current image preview to the background which was in place before the live preview. This logic now changes the preview of the current background preview to the background which was previously set. Normally this isn't noticeable with one exception: When the user manually changed the background through external means, e.g. the gnome settings.

Steps to reproduce:

  1. Have a normal history
  2. Change the wallpaper in the gnome settings to an image not in the RWG3 history
  3. Open the extension menu and move the mouse over some entries
  4. Move the mouse outside the menu
  5. Notice the current background preview image now being incorrect and a wallpaper not in the history

Edit: I don't know why the live hover preview isn't working for me, it should

ifl0w commented 5 months ago

Without the separating image the drop-down looks a bit awkward tho

I tried to improve on that. Unfortunately, the default separator items don't really work with submenus so I had to add a custom widget to work around that.

ifl0w commented 5 months ago

@Lucki IMO this is now an improvement to how it the UI and preview was before. I'll probably make another cleanup of the commits and commit messages but feel free to give it a try and drop your opinion here! :)

ifl0w commented 5 months ago

Cleaned up the commit history a bit and fixed a critical bug with the last commit.

ifl0w commented 4 months ago

Does the hover preview (mouse over a history element and the gnome background changes) work for you?

@Lucki Yes, sorry for not replying to that earlier. It does work for me on two different machines and in the docker container without problems :shrug: ... I also don't see why it shouldn't work. Did you maybe accidentally deactivate it in the settings (at least that just happened to me, and I was really confused it didn't work right away :sweat_smile:)?

Lucki commented 4 months ago

I had the option disabled in the past but activated it for testing. Well, if it works on so many test setups then it should be fine :shrug:

ifl0w commented 4 months ago

Yeah, I hope so! Let me know in case you find out why it isn't working for you (maybe something related to a multi monitor setup?). I guess we'll also see if others are affected when it is released.

So, I'll go ahead, merge this, and finally create a release now! :) Thanks again for all your effort and your patience!