search

ifl0w / RandomWallpaperGnome3

Random Wallpapers for Gnome 3
MIT License
178 stars 42 forks source link

Address Changes Requested for v3.0.0 #189

Closed ifl0w closed 9 months ago

ifl0w commented 9 months ago

This PR mainly collects changes required to pass the review on extensions.gnome.org.

ifl0w commented 9 months ago

Hey @Lucki, may I ask you to take a quick look at the second commit and maybe test this PR to see if you recognize any major issues?

I tried to test some edge cases manually, and for me, it seems to work, but I might not have tested cases that require the earlier logic.

ifl0w commented 9 months ago

I think I just found out why my hover preview doesn't work anymore: I'm using dark mode and we must have lost setting the picture-uri-dark somewhere.

@Lucki, I understand that this could be a problem in general as there are a few places where we use picture-uri, and it looks like we might not consider the picture-uri-dark correctly. However, the hover preview still works for me in the dark UI mode. Are you sure it is only due to the dark mode in your case?

Lucki commented 9 months ago

However, the hover preview still works for me in the dark UI mode. Are you sure it is only due to the dark mode in your case?

Sorry, I only saw one entry change in dconf, might have been because the HydraPaper process got killed. I should have tested light mode, it also doesn't work for me there.

Debugging is particularly annoying since Gnome 45 because the gnome shell crashes instead of reloading. I'll give that workaround a try later.

ifl0w commented 9 months ago

Debugging is particularly annoying since Gnome 45 because the gnome shell crashes instead of reloading. I'll give that workaround a try later.

I feel your pain! For me, gnome shell on x-org crashes when restarting it :sweat_smile: ... the linux container is currently my only debug/test workflow on my main machine.

Lucki commented 9 months ago

Many console.log() later: #190