search

ifl0w / RandomWallpaperGnome3

Random Wallpapers for Gnome 3
MIT License
176 stars 40 forks source link

Configurable zoom mode setting #194

Closed Lucki closed 3 months ago

Lucki commented 3 months ago

Fix #192

Maybe there's better wording for zoom mode. Gnomes own 'picture-options' is somewhat meaningless though.

Lucki commented 3 months ago
  • Should we store/replicate the picture-options value in our schema? I tend to no, but see my other comments for further thoughts.

As a user I wouldn't expect my setting to change randomly by using other programs. So I think we should save and apply our own value. And similarly we would have to tie the multi monitor setting somehow to the scaling setting to get back out of the spanned mode.

Also saving this setting separately could be beneficial if we implement HydraPaper's --modes [mode, mode…] option. See #195

  • Should we expose an option to change the background color as well (relevant for centered/scaled)? I guess, we can address that in a separate PR anyway, so this is not so important here.

Not sure about this one. The random wallpapers will make the color always be incorrect. Best would be a neutral color to adapt to as many wallpapers as possible. We could also hardcode such a color, e.g. black :shrug:

ifl0w commented 3 months ago

As a user I wouldn't expect my setting to change randomly by using other programs. So I think we should save and apply our own value.

You have a point there. We probably also should reset the zoom mode to the default value when disabling the extension.

Not sure about this one. The random wallpapers will make the color always be incorrect. Best would be a neutral color to adapt to as many wallpapers as possible. We could also hardcode such a color, e.g. black 🤷

I think, that it should be a user's choice what color they want to use, but let's address this separately.