ifl0w / RandomWallpaperGnome3

Random Wallpapers for Gnome 3
MIT License
176 stars 41 forks source link

Allow to set "scaled" mode instead of zoom. #195

Open laerne opened 6 months ago

laerne commented 6 months ago

Some image provider like Artstation do not care about providing images in landscape ratios. In portrait images, using the default fit mode 'zoom' is devastating, often showing only the lower bust and the hips of a character. I would suggest to add an option to allow to use the 'scaled' mode instead and fit the entire background image inside the display.

This is a draft; I couldn't figure out how to read the settings from the various wallpaper managers.

Lucki commented 6 months ago

this PR addresses a similar issue as #194.

Somewhat. This also exposes a setting in HydraPaper, on how to manipulate the images inside the resulting single spanned image.

I'd suggest you concentrate on interaction with HydraPaper, as #194 already covers the overall scaling setting. To be precise:

I couldn't figure out how to read the settings from the various wallpaper managers.

Can you be more precise? What settings are you trying to read?


I wasn't aware of the blur ability of HydraPaper. This might be a valid reason to make the external manager able to handle single wallpaper as well.

Lucki commented 4 months ago

The conflicting PR from me is now implemented. You may want to rebase now and continue from there. My previous comment is still valid I think.