ifmeorg / ifme

Free, open source mental health communication web app to share experiences with loved ones
http://www.if-me.org/
GNU Affero General Public License v3.0
1.49k stars 740 forks source link

Improve aria-label values in non-text links in the StoryActions component #2121

Closed julianguyen closed 2 years ago

julianguyen commented 2 years ago

Description

The Story component (code) appears on many pages, including the signed-in homepage when there are viewable Moments or Strategies and any signed-in page that's displaying a list of items.

The StoryActions sub-component has non-text links (icons with tooltips) for functionality like editing and deleting. There are existing values for aria-label on these non-text links, but they should be improved.

Let's include the name of the story that the action is being applied to. The change should be made here, and we should concatenate the prop name from Story to this string.

e.g. "Edit Story-Name-Here"

We'll have to account for internationalization (i18n) for different grammar structures in different languages. Feel free to defer to Google Translate for verification.


Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!