ifmeorg / ifme

Free, open source mental health communication web app to share experiences with loved ones

http://www.if-me.org/

GNU Affero General Public License v3.0

1.46k stars 734 forks source link

Add a Storybook build to our Circle CI configuration #2163

Open julianguyen opened 1 year ago

julianguyen commented 1 year ago

Description

Let's add a Storybook build to our Circle CI configuration. We need to verify that merges to our repo do not break the Storybook build. If there are changes to files in /client, we want to verify that the Storybook build passes before a PR is mergeable.

Please assign yourself (via the Assignees dropdown), if you do want to work on this issue. Can't find yourself? You need to join our organization.

Check out our Picking Up Issues guide if you haven't already!

cristianmedeiros commented 1 year ago

Will give it a try

julianguyen commented 1 year ago

That would be great, thank you, @cristianmedeiros!

rajat-tomar commented 1 year ago

@cristianmedeiros are you working on this?

cristianmedeiros commented 1 year ago

Hi Rajat, yes, slowly, but yes

On Mon, Oct 17, 2022 at 11:13 AM Rajat Tomar @.***> wrote:

@cristianmedeiros https://github.com/cristianmedeiros are you working on this?

— Reply to this email directly, view it on GitHub https://github.com/ifmeorg/ifme/issues/2163#issuecomment-1280928549, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIAT6AN73ZSYLB3YHB6TTWDVNIHANCNFSM6AAAAAARAYLLA4 . You are receiving this because you were mentioned.Message ID: @.***>

rajat-tomar commented 1 year ago

Hi Rajat, yes, slowly, but yes … On Mon, Oct 17, 2022 at 11:13 AM Rajat Tomar @.> wrote: @cristianmedeiros https://github.com/cristianmedeiros are you working on this? — Reply to this email directly, view it on GitHub <#2163 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAIAT6AN73ZSYLB3YHB6TTWDVNIHANCNFSM6AAAAAARAYLLA4 . You are receiving this because you were mentioned.Message ID: @.>

Ohh ok! just wanted to confirm. Thanks for confirming @cristianmedeiros !😊

cristianmedeiros commented 1 year ago

hi @rajat-tomar I probably won't finish it today to hacktoberfest, do you want to assing this issue for you?

rajat-tomar commented 1 year ago

It's okay @cristianmedeiros, Hacktoberfest is anyways ending now. You should give it one more shot. For now, I'm working on some other priority projects. Just let me know if you need any help regarding this else I'll be happy to pick this up this weekend.

sbpipb commented 1 month ago

this issues seems to be inactive and i'm assuming is available. will work on this now.