search

ifmeorg / ifme

Free, open source mental health communication web app to share experiences with loved ones
http://www.if-me.org/
GNU Affero General Public License v3.0
1.46k stars 734 forks source link

Extend make visible in stats #2168

Closed uzorjchibuzor closed 1 year ago

uzorjchibuzor commented 1 year ago

Closes #2142

Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!

uzorjchibuzor commented 1 year ago

Is there a reason why the tests that are failing are not even remotely related to the things I did?

LMulvey commented 1 year ago

Is there a reason why the tests that are failing are not even remotely related to the things I did?

@uzorjchibuzor You likely have conflicting local settings for things like ESLint and Prettier–I know I did. Navigate to ifme/client and run yarn lint locally and then commit those changes–that will sync everything up with what CI expects! 💪🏻

uzorjchibuzor commented 1 year ago

Is there a reason why the tests that are failing are not even remotely related to the things I did?

@uzorjchibuzor You likely have conflicting local settings for things like ESLint and Prettier–I know I did. Navigate to ifme/client and run yarn lint locally and then commit those changes–that will sync everything up with what CI expects! 💪🏻

I wanted to install a VSCode extension before I tried your suggestion. Hope it works. My Linting is horrible.

uzorjchibuzor commented 1 year ago

I think I passed ESLint, CircleCI is Capybara, Let me know if I need to fix anything.