Closed saminarp closed 1 year ago
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack.
Hello, I made a mistake force pushing the changes, please do not merge it. I will be creating a separate branch and push the updated PR
Description
With the following changes in
client/app/components/Header/Header.scss
, the navbar will be sticky.More Details
The fixed navbar is not supported in mobile view. I intentionally left it out because the background is transparent in the navbar (i.e, background: transparent;) Giving the navbar a subtle color would prevent any clashes from occurring as a result of scrolling.
Corresponding Issue
This enhancement addresses the issue https://github.com/ifmeorg/ifme/issues/2155.
Screenshots
Current behavior: navbar is in fixed position even with the scoll.
The screenshot below is the background color I would propose using but haven't implemented yet.
This would prevent the clashes with logo and content on the scroll
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!