ifmeorg / ifme

Free, open source mental health communication web app to share experiences with loved ones
http://www.if-me.org/
GNU Affero General Public License v3.0
1.46k stars 734 forks source link

UX: Navigation bar fixed #2176

Closed saminarp closed 6 months ago

saminarp commented 1 year ago

Description

This is my follow up PR from https://github.com/ifmeorg/ifme/pull/2171 as I mistakenly force-pushed my commit.

With the following changes in client/app/components/Header/Header.scss and app/assets/stylesheets/static/static_content.scss, the navbar will be sticky.

I have added margin-top to the main content of the page as requested in https://github.com/ifmeorg/ifme/pull/2171#discussion_r994865709

More Details

As. @julianguyen pointed out in https://github.com/ifmeorg/ifme/pull/2171 the background color $black-80 The result will look like this. However, I haven't made this change yet and wanted to ask if this is the desired result. :) If so, please let me know and I will make the necessary changes.

CleanShot 2022-10-16 at 03 30 21@2x

Corresponding Issue

https://github.com/ifmeorg/ifme/issues/2155


Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!

julianguyen commented 1 year ago

Any updates here?