search

ifmeorg / ifme

Free, open source mental health communication web app to share experiences with loved ones
http://www.if-me.org/
GNU Affero General Public License v3.0
1.48k stars 741 forks source link

Specs with js set to true fail in the Docker container created with this Dockerfile #317

Closed the-bass closed 7 years ago

the-bass commented 8 years ago

Running all specs in the Docker container created with the Dockerfile, that is part of this repository, results in 2 failing specs. The reason in both cases is

Selenium::WebDriver::Error::WebDriverError:
       Could not find Firefox binary (os=linux). Make sure Firefox is installed or set the path manually with Selenium::WebDriver::Firefox::Binary.path=

Is this by design or should the dependecy be added to the Dockerfile?

julianguyen commented 8 years ago

@esBeee Selenium should be running properly. Perhaps add it to the dockerfile?

julianguyen commented 8 years ago

Also, do you have Firefox installed?

the-bass commented 8 years ago

I have Firefox install on my machine, but it's not accessible from inside a Docker container. I wasn't able to find a simple solution for that problem, but since I'm a user of Docker Compose anyways, I implemented a solution using it. I don't know whether this is where you want to go with Docker, but I've created a pull request, so it's up to you to decide. #332