search

ifndefdeadmau5 / react-floating-button-menu

A customizable floating action button menu that follows material design
https://ifndefdeadmau5.github.io/react-floating-button-menu/
45 stars 15 forks source link

JSS to CSS or SCSS #47

Open tanohzana opened 3 years ago

tanohzana commented 3 years ago

I am just opening this issue to sum up what you wrote in your TODOs. I can definitely do that over the week end if you're down, then open a PR so you can review and merge 😉 Would you prefer CSS or SCSS ?

tanohzana commented 3 years ago

Also, I would need to create folders for each Component so it does not get messed up with all JSX and SCSS files in the same folder. Does this architecture suit you :

ComponentXXX [folder] -- ComponentXXX.jsx

-- ComponentXXX.scss | -- index.js

ifndefdeadmau5 commented 3 years ago

Thanks for raising this issue @tanohzana , currently the library itself doesn't contain any styling solution but does have a 'styled-components' as a peer dependency and this is also kinda bad.

I'd gladly review your work if you're willing to contribute, but before that I'm planning to rewrite this package to get rid of old tools it depending on, so I think it'd be much better if you working on it afterwards. What's your thought?

tanohzana commented 3 years ago

No problem. I'd be glad to help. Just say the word 🙂

ifndefdeadmau5 commented 3 years ago

@tanohzana I've done rewriting recently via this commit b2a94b7a68507631580f6b3c0a2cc949801edc94 and I also wanna double check if there's a workaround for keeping 3rd party styling solution because I still want to keep good developer experience too, otherwise I'll finally decide to work on that you suggested at first.