search

ifosch / accloudtant

AWS cost calculator
59 stars 19 forks source link

Check flake8 errors #66

Open ifosch opened 8 years ago

ifosch commented 8 years ago

Check errors when using flake8 on repo root:

$ flake8 --max-complexity 5
./accloudtant/aws/reports.py:17:1: C901 'Reports.find_reserved_instance' is too complex (6)
./accloudtant/aws/instance.py:79:1: C901 'Instance.match_reserved_instance' is too complex (7)
./tests/aws/conftest.py:44:1: C901 'ec2_resource' is too complex (9)
./tests/aws/conftest.py:73:1: C901 'ec2_client' is too complex (8)
./tests/aws/conftest.py:101:1: C901 'mock_requests_get' is too complex (6)
./tests/aws/conftest.py:125:1: C901 'process_ec2' is too complex (7)

It would be great to fix these over complexity, even when happening in tests.

vabada commented 8 years ago

Updated:

$ flake8 --max-complexity 5
./accloudtant/aws/reports.py:27:1: C901 'Reports.__init__' is too complex (9)
./tests/aws/conftest.py:58:1: C901 'ec2_resource' is too complex (14)
./tests/aws/conftest.py:95:1: C901 'ec2_client' is too complex (10)
./tests/aws/conftest.py:135:1: C901 'mock_requests_get' is too complex (6)
./tests/aws/conftest.py:160:1: C901 'process_ec2' is too complex (7)