search

ifosch / keepass-mode

Emacs mode to open KeePass DB
https://github.com/ifosch/keepass-mode
GNU General Public License v3.0
40 stars 7 forks source link

Add feature: copy user name with `b` #12

Closed ykgoon closed 3 years ago

ykgoon commented 3 years ago

This is related to issue #11.

The code isn't very DRY but it works. I don't mind doing more to make it so later on.

ykgoon commented 3 years ago

Code made DRY now.

Next I wanna see how best to do a help-guide. Any suggestion?

ifosch commented 3 years ago

Next I wanna see how best to do a help-guide. Any suggestion?

I'm not sure what do you mean with help-guide, but sounds something worth to open a separate issue, and not blocking this PR.

ykgoon commented 3 years ago

Went through all comments. Test case now passes.

ykgoon commented 3 years ago

Updated README to reflect new keys too.

ifosch commented 3 years ago

Thanks for the changes. I'm afraid I must ask you to add tests for the new cases, as we have for copying a password, so for copying a user name and a URL. I think with these, this will be ready to merge.

ykgoon commented 3 years ago

I've added two test cases. It's mostly done via mimicry, dunno if it's good enough.

@ifosch do comment if it's not.

ifosch commented 3 years ago

Looks perfect

ifosch commented 3 years ago

This solves #11