ifrotz / iosfrotz

Frotz for iOS source (formerly at code.google.com/p/iphonefrotz)
Other
49 stars 17 forks source link

Images won't upload to iFrotz properly #193

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
[Please glance at the existing issues to make sure the problem you are
reporting  isn't a known issue before reporting.  Feel free to remove or
edit any parts of the form template which don't apply to your issue.]

What steps will reproduce the problem?
1. Use the web interface to transfer an image for a game that has a number of 
save games listed (and also linked to Dropbox). I used Advent.z5, downloaded 
from the IF Archive.

What is the expected output or behavior?  What do you see instead?
Expected to see the image appear against the name of the game in the web 
interface. Instead, no image appears, and no image appears in the app on the 
iPad either. On further investigation, the image was found in the Saves folder.

What version of Frotz are you using?
1.6

What device model are you using (e.g., iPhone 4S, iPhone 3GS, iPad 2, iPad 2

What version of iOS?  4.2.1, 5.1, etc.)
5.11

Please provide any additional information below.
I notice that this bug is similar to one that is now labelled fixed. Is it only 
fixed for iOS 6? I'm still on iOS 5.11.

Original issue reported on code.google.com by cxde...@gmail.com on 27 Oct 2012 at 10:35

GoogleCodeExporter commented 9 years ago
Could you please specify what was the file name of the image you tried to 
upload? Was it a jpg or png?  Thanks. 

Original comment by spath...@gmail.com on 28 Oct 2012 at 3:57

GoogleCodeExporter commented 9 years ago
Well, crap, never mind, it easily reproduces with any image filename.
I could have sworn I tested this and it worked after fixing an issue with 
spaces in filenames, but after that I made a change so the default images for 
built-in games won't get backed up if you have iCloud backups for apps turned 
on (which I've heard is required to avoid App Store rejection).   Apparently I 
screwed up and broke this again.
I'll fix it in the next update.  In the mean time, you can get images into 
Frotz by turning on "Story Info Editing" in the prefs, and then using 
copy/paste. Copy an image from Safari (or anywhere else), then 'Edit' the story 
info for Advent or whichever game, long press the image, and select 'Paste'.

Original comment by spath...@gmail.com on 28 Oct 2012 at 6:25

GoogleCodeExporter commented 9 years ago
Thanks for the response. Uploading images via the web interface actually seems 
to work for game files which have never had an image uploaded before and which 
didn't come bundled with an image in iFrotz. I found that Cold Iron accepted an 
image, for example.

Btw, your copy/paste workaround doesn't change the thumbnail image in the Story 
List on iPad. It only changes the fullscreen Story Info image.

But thank you for all your hard work on this essential app. I complain so much 
only because I love it!

Original comment by cxde...@gmail.com on 28 Oct 2012 at 11:45

GoogleCodeExporter commented 9 years ago
Thanks for the additional info.

The thumbnail will update as soon as the image is used as a splash launch 
image.  So, save your game, quit, launch the game again, then restore, and the 
thumbnail image will be there.

Original comment by spath...@gmail.com on 28 Oct 2012 at 2:58

GoogleCodeExporter commented 9 years ago
> The thumbnail will update as soon as the image is used as a splash launch 
image.

True *unless* you upload image1 using the web interface and then try to replace 
it with image2 using the copy/paste method in iPad. In this case, the image1 
thumbnail doesn't change to image2.

Original comment by cxde...@gmail.com on 28 Oct 2012 at 4:37

GoogleCodeExporter commented 9 years ago
Corrections/clarifications.

In my Comment 3 above, I meant to say "Uploading images via the web interface 
seems to work for any game file that satisfies all three of the following 
conditions: (1) the game file has never had an image uploaded before; (2) the 
game file didn't come bundled with an image in iFrotz; and (3) the game file 
has never been played and has no associated save games." (I'm not entirely sure 
about the details of condition 3.)

I'm no longer sure that my Comment 5 is correct. The copy/paste workaround 
*does* work, but seemingly only after you restart the iPad. It doesn't seem to 
work if you just quit and restart the game or even if you quit and restart both 
the game and then the Frotz app.

Sorry for the confusion.

Original comment by cxde...@gmail.com on 29 Oct 2012 at 5:01

GoogleCodeExporter commented 9 years ago
No problem, I appreciate the input.  Thanks for taking the time.

Original comment by spath...@gmail.com on 29 Oct 2012 at 6:13

GoogleCodeExporter commented 9 years ago
Hey guys, I think I am experiencing the same issue as discussed here, but just 
to make sure I shall try to describe.

My platform is a 32 gig ipad 4, latest version of Frotz and latest version of 
iOS.
I LOVE LOVE LOVE your app.

I add a story file to Frotz. Some already have embedded data in them (Written 
by, TUID Identifier, a cover image, and a description).
Others do not.

I haven't been able to determine why or how some do or don't in terms of the 
process of importing them. 

I am able to select the story file, then at the title screen I can EDIT it, 
update the story name, add written by info, add TUID (which i paste in directly 
from IFDB), and do the long hold paste to put my image in the cover image spot. 
These 4 bits seem to work all the time, and once I put them in they stay there 
as I would expect. The TUID seems to link correctly to the appropriate entry in 
the IFDB.

I am seeing 2 areas with problems though. 1st is the thumbnail image in the 
story list for the respective story file. Some of my story files have a 
thumbnail and others do not. When they do have a thumbnail, it always matches 
the cover image (such as the one I long-pasted in).
I haven't been able to get an image that I added, to show up as a thumbnail. 
Basically if the story file has the default compass "no image" icon as the 
thumbnail for the story file then I cannot get it to update. I have tried 
sequences as described above of saving and restarting the story file, rebooting 
the ipad in various forms, etc. If there is an exact sequence that seems to 
work consistently please let me know.

The other (possibly seperate?) point of confusion is that I cannot ever get the 
"description" to update. It almost looks like it should be associated somehow 
with the IFDB description/TUID but I am not sure why some seem to get the 
description and others do not. I have no way to paste one in or update it. 
Basically some of my story files have a nice description that looks like it was 
referenced directly from the IFDB but some just say No description Available, 
and I can't ever seem to update them.

If I can provide any extra info please let me know.
Thanks!
Clint

Original comment by Richards...@gmail.com on 3 Jan 2014 at 3:04

GoogleCodeExporter commented 9 years ago
So one big factor in whether the uploaded image 'sticks' or not turns out to be 
the case of the story filename.
There was a bug where a filename compare was incorrectly case sensitive.  Story 
names that are lower case accept  uploaded images correctly.  Mixed case story 
names winded up getting the uploaded image placed in the game Saves directory 
incorrectly.  I've fixed this.

Another thing -- games in blorb format which have embedded splash images will 
always use that image, even if you upload new one to be used for the story 
details page and story list  thumbnail. I don't think I'm going to change this, 
because it's the original intent of the author, and in the case of glulx games, 
the game itself controls displaying images anyway.

Original comment by spath...@gmail.com on 21 Jul 2014 at 4:53

GoogleCodeExporter commented 9 years ago

Original comment by spath...@gmail.com on 14 Aug 2014 at 7:46

GoogleCodeExporter commented 9 years ago
Fixed in release 1.7, now available (as soon as App Store servers update).

Original comment by spath...@gmail.com on 22 Aug 2014 at 4:21