ifrotz / iosfrotz

Frotz for iOS source (formerly at code.google.com/p/iphonefrotz)
Other
49 stars 16 forks source link

Hangs scrolling settings #308

Closed msp42 closed 3 years ago

msp42 commented 4 years ago

Frotz 1.8.5 iOS 13.6.1 iPhone 7 Plus

Every time I go to the Settings menu and scroll below Story Info Editing it stops responding.

msp42 commented 4 years ago

Apart from the hang, Frotz is working very well. Great work!

spathiwa commented 4 years ago

So, I don't have a physical iPhone 7 Plus or other large-screen iPhone, but I was able to reproduce a hang in the emulator, but only in Landscape mode. If I stick to portrait, the hang doesn't seem to happen.

Does that match what you're seeing?

The hang I've reproduced seems to be stuck in a iOS routine which automatically lays out views; there's no actual Frotz code on the stack, so it's probably an iOS bug, but I still may be able to figure out how to work around it and patch for it.

spathiwa commented 4 years ago

Scratch that. Under iOS 10.x (which shipped with the iPhone 7 Plus and is what the emulator was using by default) it happens only on landscape, but under iOS 13.x it hangs in portrait mode too.

Fortunately, I figured out the issue and have a fix. Turns out it was Frotz's fault after all, although arguably the OS still shouldn't hang because of it.

Gonna wait a couple days and see if any other serious issues worth fixing show up, and then put up a new version.

Thanks for reporting this!

msp42 commented 4 years ago

Thank you for all your hard work! Frotz is ace!!

Cheers Mark Phillips

Sent from my iPhone

On 5 Sep 2020, at 08:44, Craig Smith notifications@github.com wrote:



Scratch that. Under iOS 10.x (which shipped with the iPhone 7 Plus and is what the emulator was using by default) it happens only on landscape, but under iOS 13.x it hangs in portrait mode too.

Fortunately, I figured out the issue and have a fix. Turns out it was Frotz's fault after all, although arguably the OS still shouldn't hang because of it.

Gonna wait a couple days and see if any other serious issues worth fixing show up, and then put up a new version.

Thanks for reporting this!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ifrotz/iosfrotz/issues/308#issuecomment-687567463, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AIDCLQLAQ5ODFTFEKKG4PX3SEHT4TANCNFSM4QXR6HLQ.

spathiwa commented 3 years ago

Fixed in 1.8.6.