search

ifsnop / mysqldump-php

PHP version of mysqldump cli that comes with MySQL
https://github.com/ifsnop/mysqldump-php
GNU General Public License v3.0
1.25k stars 300 forks source link

deflate_* functions were only added on PHP 7 #208

Open Luc45 opened 4 years ago

Luc45 commented 4 years ago

The CompressGzipstream uses some functions that were only added on PHP 7:

----------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
 1476 | ERROR | The function deflate_init() is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.FunctionUse.NewFunctions.deflate_initFound)
 1476 | ERROR | The constant "ZLIB_ENCODING_GZIP" is not present in
      |       | PHP version 5.6 or earlier
      |       | (PHPCompatibility.Constants.NewConstants.zlib_encoding_gzipFound)
 1483 | ERROR | The function deflate_add() is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.FunctionUse.NewFunctions.deflate_addFound)
 1483 | ERROR | The constant "ZLIB_NO_FLUSH" is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.Constants.NewConstants.zlib_no_flushFound)
 1492 | ERROR | The function deflate_add() is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.FunctionUse.NewFunctions.deflate_addFound)
 1492 | ERROR | The constant "ZLIB_FINISH" is not present in PHP
      |       | version 5.6 or earlier
      |       | (PHPCompatibility.Constants.NewConstants.zlib_finishFound)
----------------------------------------------------------------------
ifsnop commented 4 years ago

I think we should better rollback this commit. I appreciate backwards compatibility.