search

ifsnop / mysqldump-php

PHP version of mysqldump cli that comes with MySQL
https://github.com/ifsnop/mysqldump-php
GNU General Public License v3.0
1.25k stars 300 forks source link

PHP 8.2 deprecate ${} string interpolation #247

Closed heian-web closed 1 year ago

heian-web commented 2 years ago

As per https://wiki.php.net/rfc/deprecate_dollar_brace_string_interpolation I noticed that this library extensively uses this syntax, which will effectively break it in PHP 9 (still a while before this happens) and may start to spam with deprecation notices quite soon. A simple and fast code refactoring should solve this.

faizanakram99 commented 1 year ago

This is taken care in https://github.com/druidfi/mysqldump-php fork. See #251

I appreciate the effort made in forking and maintaining the repo, but as long as the author of this repo doesn't suggest any other fork as replacement or doesn't abandon this repo, I see no reason to "comment everywhere" here is the new fork. Looks spammy to me tbh.

Replacing ${} with {$} is a small fix, doesn't need a full rewrite and I'm sure if a PR is made with just the fix @ifsnop will be kind to merge it (unless ofc it's decided to not support this repository)

ifsnop commented 1 year ago

Already merged. Thanks for the contribution. I also agree that there is no need to spam with other forks. All efforts are welcome, but lets keep things where they belong.