CompressNone performance improvements

ifsnop / mysqldump-php

PHP version of mysqldump cli that comes with MySQL

https://github.com/ifsnop/mysqldump-php

GNU General Public License v3.0

1.25k stars 300 forks source link

Closed roeycohen closed 2 months ago

roeycohen commented 2 months ago

add buffering to CompressNone as it works much faster

roeycohen commented 2 months ago

this relates to PR #280 but takes a different approach.

p.s. tiny writes don't seem to affect zip streams performance - it probably already have some kind of buffering.

roeycohen commented 2 months ago

hi @ifsnop, do you need me to make more adjustments to confirm this PR?

ifsnop commented 2 months ago

Just give me some a couple of days, testing machine break and i would like to make some more tests.

ifsnop commented 2 months ago

I think I prefer #280 over #284, since less calls to compressManager looks better to me.