search

iftechfoundation / ifdb-suggestion-tracker

Bugs and feature requests for a future IFDB update
10 stars 0 forks source link

Mysterious failure adding new off-site review to _Adventure_ #393

Closed jtn20 closed 10 months ago

jtn20 commented 1 year ago

I'm having trouble adding a new 'Off-Site Review' to the listing for Crowther & Woods' Adventure.
(Not sure if this is an outright bug or database trouble or my error or what. I reported this to the ifdbadmin email address, and they suggested I bring it here.)

Lately I've been going through and adding links to 50 Years of Text Games to relevant works, most recently to Zork on 27 July.

However, trying to do the same to Adventure fails oddly. (It was failing on 31 July, and again when I tried it just now.)

Procedure: (as IFDB user 'JTN')

  1. From 'viewgame', click 'Edit This Page'
  2. Under 'Off-Site Reviews', click 'Add a Link'
  3. Click 'Edit' on the new link, and enter details on the 'Edit Review Link' popup:
  1. Click 'Close' on the 'Edit Review Link' popup
  2. Click 'Save Changes'

Normally, I think I'd be taken back to 'viewgame'. However, in this case, I'm returned to a page with URL https://ifdb.org/editgame?id=fft6pu91j85y4acv, looking much as before, except that the 'Off-Site Reviews' list is empty -- it contains neither my new entry nor any of the existing entries (SPAG, Just Adventure, Gaming Enthusiast).
I can't see any error messages or anything.

If I go back to 'viewgame', there's no sign of my edit. The existing off-site reviews are still present.

(I doubt it'll be relevant, but my browser is Firefox 102.13.0esr; I'm the one who had trouble with the cross-site scripting changes (since worked around by Dan Fabulich).)

alice-blue commented 1 year ago

I tried something similar to what you've described (the differences are just that I used just "50 Years of Text Games" for the web site name, and different summary text), and I got the same result you did.

After that, I tried clicking "reset," but the page did not reset to before the changes. It still showed no off-site reviews.

I did not try saving the page when the edit page was not showing any off-site reviews.

jtn20 commented 1 year ago

Something I've just noticed about the IFDB entry for Adventure: in its list of "Spoofs" is "Not Found" by "Unknown". The game link for that goes to a page saying "Error: This game was not found in the database" (I guess it used to exist but was removed -- Wayback Machine has the same in Sep 2019).

I've no basis for this guess (and I haven't looked at the code), but I wonder if this dangling reference is failing some integrity constraint, preventing unrelated updates to the Adventure entry? (The last update listed is in August 2019.)

dfabulich commented 10 months ago

I think I've fixed it (by bumping up max_input_vars in php.ini)