iftechfoundation / ifdb-suggestion-tracker

Bugs and feature requests for a future IFDB update
10 stars 0 forks source link

IF Archive uploader doesn't create a pending link if the user doesn't save changes #419

Open dfabulich opened 10 months ago

dfabulich commented 10 months ago

Edit a game and click on the the "Upload it to the IF Archive" link. Upload a file to the IF Archive. This will create an ifarchive-pending link in the External Links table.

… but that table won't actually get saved to the DB unless you have the presence of mind to click "Save Changes" at the bottom of the page.

If you don't have the presence of mind to Save Changes, or if you delete/edit the pending URL, or if you navigate directly to https://ifdb.org/ifarchive-upload (so there's no window.opener), the IF Archive upload will succeed, and the archive team will run ifdbize.py to call the /ifarchive-commit API on IFDB, but it will fail with the error, "Error: no link found to this pending URL", so IFDB won't get updated.