search

iftechfoundation / ifdb-suggestion-tracker

Bugs and feature requests for a future IFDB update
10 stars 0 forks source link

IF Archive uploader includes an ifdbid even when there's no window.opener #420

Closed dfabulich closed 7 months ago

dfabulich commented 7 months ago

Normally we expect users to edit a game and click the "Upload it to the IF Archive" link there. That will open a new tab, pointing to a page like this:

https://ifdb.org/ifarchive-upload?title=Counterfeit%20Monkey&system=Inform%207&license=Creative%20Commons&author=Emily%20Short%20%7B4onqcn9pq2wtd3vb%7D&version=11

That page will generate a random string, called the ifdbid, and submit that as a parameter when uploading to IF Archive, and, when you submit the form, it will use JS to talk to the window.opener, inserting a new link like this:

https://ifdb.org/ifarchive-pending?ifdbid=$ifdbid

But the problem is, our IF Archive uploader will generate and transmit an ifdbid even if there's no window.opener. In that case, the ifdbid won't be saved as an ifarchive-pending link, so when the archive team runs ifdbize.py, it will fail with an error, "Error: no link found to this pending URL"

dfabulich commented 7 months ago

Eh, this is just a variation on #419.