Open dfabulich opened 6 months ago
Maybe we should get rid of "Tags matched" entirely.
https://github.com/iftechfoundation/ifdb/pull/269#issuecomment-1871463220
I changed it to use a join, in a separate commit. You can decide which is better.
Based on tests, I think I'm correct in my assumption that in the current behavior, searching for multiple tags
AND
s them. If that's the case, what's the point of each result having a label of "Tags matched: A B C"? Why not have those links at the top of the list?
https://ifdb.org/search?searchbar=tag%3Apunyjam
There are two tags in IFDB,
punyjam
andPunyJam #3
. This search will only search for games that have thepunyjam
tag.Actual: For Submarine Sabotage, it says "Tags matched: PunyJam #3" Expected: "Tags matched: punyjam" (or get rid of "Tags matched" entirely… see below)
@salty-horse explains:
https://github.com/iftechfoundation/ifdb/pull/269#issuecomment-1873999295