Closed salty-horse closed 6 months ago
User pages with emails have a "click to reveal" link which should open a captcha. Example: https://ifdb.org/showuser?id=sewum1c69z4rchuz
Clicking the link does nothing.
From what I gather, it's because the captcha has the class hidden which defines display: none !important;. When the click script tries to set display to block, the more-important CSS definition overrides it.
hidden
display: none !important;
display
block
The inline style was removed as part of the security fixes here: https://github.com/iftechfoundation/ifdb/commit/52213b2f088e3d7e17438d3f750f3f38b7870a44 And the CSS definition for hidden was added for a different feature: https://github.com/iftechfoundation/ifdb/commit/ef02d3d4c370752098aeae289868982f278c7a14
Maybe the easiest solution would be to have a hidden_captcha style that's not !important.
hidden_captcha
!important
User pages with emails have a "click to reveal" link which should open a captcha. Example: https://ifdb.org/showuser?id=sewum1c69z4rchuz
Clicking the link does nothing.
From what I gather, it's because the captcha has the class
hiddenwhich definesdisplay: none !important;. When the click script tries to setdisplaytoblock, the more-important CSS definition overrides it.The inline style was removed as part of the security fixes here: https://github.com/iftechfoundation/ifdb/commit/52213b2f088e3d7e17438d3f750f3f38b7870a44 And the CSS definition for
hiddenwas added for a different feature: https://github.com/iftechfoundation/ifdb/commit/ef02d3d4c370752098aeae289868982f278c7a14Maybe the easiest solution would be to have a
hidden_captchastyle that's not!important.