search

iftechfoundation / ifdb

The software behind the Interactive Fiction Database (IFDB)
Other
23 stars 18 forks source link

search: Make `played:yes` filter include games you've reviewed/rated #334

Closed dfabulich closed 1 week ago

dfabulich commented 2 weeks ago

Fixes https://github.com/iftechfoundation/ifdb/issues/385

salty-horse commented 2 weeks ago

I wonder if it should work differently, where rating a game will also mark it as "played", with a flag that it was done automatically due to a rating.

And delete all ratings/reviews for a game, it should check if "played" was an automatic marking, and delete that too.

salty-horse commented 2 weeks ago

Does it make sense to have a separate reviewed:yes query to only search games you're reviewed?

dfabulich commented 2 weeks ago

I'm unsure what the right approach is; I opened a thread about it on the intfiction forum here. https://intfiction.org/t/ifdb-played-yes-and-ratings-reviews/71269

dfabulich commented 1 week ago

I'm closing this out, in favor of https://github.com/iftechfoundation/ifdb/issues/383