iftechfoundation / ifdb

The software behind the Interactive Fiction Database (IFDB)
Other
23 stars 18 forks source link

Cut off "Play Online" button on games with external links to zips containing long file names #403

Closed dfabulich closed 1 month ago

dfabulich commented 1 month ago

https://ifdb.org/viewgame?id=5torplpwdtjlbdlo https://ifdb.org/viewgame?id=89l87vzipgq8xgi0 https://ifdb.org/viewgame?id=jtgfw8y4x0rrohr

image
dfabulich commented 1 month ago

I halfway fixed this with https://github.com/iftechfoundation/ifdb/commit/e2c4361b4c28a101296c5646af7336439086d80b but it's still broken when the link title or compressedprimary is very long and contains no spaces, dashes, underscores, or slashes, e.g. http://localhost:8080/viewgame?id=5torplpwdtjlbdlo

image
dfabulich commented 1 month ago
select * from gamelinks where title not like '% %' and title not like '%/%' and title not like '%\_%' and title not like '%-%' order by length(title) desc limit 20 \G
dfabulich commented 1 month ago

@salty-horse Do you have any idea why this is broken? I'm struggling to understand the layout issue.

dfabulich commented 1 month ago

https://github.com/iftechfoundation/ifdb/commit/77808abe554d588bd043693f7b657ab51ff2528b fixed it.