iftechfoundation / ifdb

The software behind the Interactive Fiction Database (IFDB)
Other
25 stars 18 forks source link

Game without name or author is not hyperlinked properly #622

Open salty-horse opened 3 years ago

salty-horse commented 3 years ago

When listing all games by lowest rating, this appeared at the top:

, by

The markup is: <p><a href="viewgame?id=z4pe4wiz6t827c23"><b> </b></a>, by <br></p>

Note the a tag is empty. Perhaps in this case, the title should show up as "Untitled", and if there's no author, the "by" should be omitted

Also, maybe delete the entry, and consider not allowing an edit that removes the name completely?

lkcampbell commented 3 years ago

@salty-horse, yup, I just found this problem myself a couple of days ago. See https://github.com/iftechfoundation/ifdb/issues/119.

salty-horse commented 1 year ago

I submitted a fix to the underlying issue, but the databases should be scanned for any empty or untrimmed fields in the games table.