Closed GoogleCodeExporter closed 8 years ago
Where is the source for the model class involved?
Original comment by guido@google.com
on 27 Jan 2012 at 3:50
Actually, I think I've found it. webapp2 has its own PickledProperty, which
subclasses BlobProperty in a way that no longer works. It should just use the
PickleProperty available in NDB.
Original comment by guido@google.com
on 27 Jan 2012 at 3:52
Another alternative is to downgrade both webapp2 and ndb: go back to
webapp2-2.3 for your webapp2_extras and go back to ndb 0.9.3 (copy that into
your appdir). That combination will continue to work. (I gather you have a copy
of webapp2_extras in your app that comes from webapp2-2.4, because that's the
first version of it that imports google.appengine.ext.ndb instead of toplevel
ndb.
Original comment by guido@google.com
on 27 Jan 2012 at 6:58
This issue was closed by revision ffc709cbdd3b.
Original comment by guido@google.com
on 27 Jan 2012 at 10:51
awesome, thanks for the fixes (yupp, had an own clone of webapp2_extras fixing
the from google.appengine.ext.ndb import issue)
Original comment by joernhees2
on 27 Jan 2012 at 11:27
Only saw this now. Thanks for fixing it, Guido. I totally missed that the tests
were still using the ndb from the lib dir.
Original comment by rodrigo.moraes
on 29 Jan 2012 at 9:52
Rodrigo, I think we'll need to release a version 2.5 to deal with this. Or
could it be 2.4.1? What's your procedure for doing releases?
Original comment by guido@google.com
on 30 Jan 2012 at 4:50
Rodrigo, do you have time to answer some specific questions?
- Do you think we should do a new webapp2 external release to fix this bug?
- If so, should we release the new version as 2.4.1 or as 2.5?
Please review http://codereview.appspot.com/5580045/
Original comment by guido@google.com
on 30 Jan 2012 at 7:21
Version numbers are somewhat random. :)
I'll do a release this afternoon. Thanks.
Original comment by rodrigo.moraes
on 31 Jan 2012 at 1:48
I added PickeProperty so that tests pass with SDK 1.6.1: revision a70c62e4b79e
Let me know if it is ok.
Original comment by rodrigo.moraes
on 31 Jan 2012 at 4:01
Ok, looks fine. Let me know if you need anything, otherwise good luck
with the release and thanks again for webapp2!!
--Guido
Original comment by guido@google.com
on 31 Jan 2012 at 6:08
Original issue reported on code.google.com by
joernhees2
on 27 Jan 2012 at 2:36