search

ifvictr / ghost-storage-github

:octocat: GitHub storage adapter for Ghost
https://npm.im/ghost-storage-github
MIT License
65 stars 12 forks source link

Update octokit #39

Closed ScottSmith95 closed 3 years ago

ScottSmith95 commented 3 years ago

This also fixes the use of old env variable names that were associated with the package before it was renamed. I dropped bluebird as a requirement since the associated functions are part of all versions of Node supported by Ghost at this point.

ifvictr commented 3 years ago

Thanks for another PR, Scott! It’d be nice if this PR was split into three separate ones:

Not a fan of changing the environment variable names—it just needlessly breaks installations and doesn’t follow semver.

ScottSmith95 commented 3 years ago

Can do. Regarding the variable names, those prefixes are created automatically so when the name of the package was changed, the env vars were changed for new installs of the adapter.

ifvictr commented 3 years ago

Maybe I'm misunderstanding what you're saying about the automatically created env names, but is this documented behavior with Ghost itself? What's creating it?