search

igaster / laravel-theme

Theme support for Laravel
MIT License
516 stars 110 forks source link

Considering, but some concerns #3

Closed TheDigitalOrchard closed 9 years ago

TheDigitalOrchard commented 9 years ago

I'm considering using your package, but I have some concerns. When adopting a third-party package, it's very important (to me) that the package is maintained over time.

While the design of this package looks very promising, there's been some red flags that have me thinking twice... for example, you've used back-slashes in your example (img\path\file.png) instead of forward-slashes. Maybe that's just silly of me, but it raises concern about quality and attention to detail within the code itself. I would need to trust the package if I were to use it in my business.

Thanks for your awesome work so far. Your package is the closest that I've found to solving my current theme-management problem. There doesn't appear to be many solutions (two?) available for Laravel.

igaster commented 9 years ago

Hello,

Thank you for spotting this. In fact it wasn't supposed to be a fully featured example. It was extracted from a question in stack overflow...

I am planing to create some more sophisticated examples over time. I'm actually using this package in my projects. You can check out a fully featured implementation in these themes:

http://www.smart-hotels.gr/en/demo1 http://www.smart-hotels.gr/en/demo2

You will notice that while those themes have complety different structure, they share some elements (eg photo gallery & some css...)

I'll be happy to respond to any questions / proposals...

TheDigitalOrchard commented 9 years ago

Thank you for the super-fast response. That alone gives me added confidence.

P.S. You may want to fix the spelling of "public" in your README... it's missing the 4th letter. :P