igaster / laravel-theme

Theme support for Laravel
MIT License
520 stars 113 forks source link

Add a third option for handling non-existent theme files #31

Closed hailwood closed 8 years ago

hailwood commented 8 years ago

This option assumes that the files do infact exist at that path. This is great for e.g. route asset management (say I have /assets/file.css that actually invokes my AssetManagementController) Or (and this one is my actual use case) you're using webpack-dev-server and so the files are stored and served in memory via a proxy.

If the asset_not_found action is 'ASSUME_EXISTS' then it will return the path relative to the active themes assetPath.

codecov-io commented 8 years ago

Current coverage is 42.50%

Merging #31 into master will decrease coverage by 0.63%

@@             master        #31   diff @@
==========================================
  Files             6          6          
  Lines           197        200     +3   
  Methods          38         38          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits             85         85          
- Misses          112        115     +3   
  Partials          0          0          

Powered by Codecov. Last updated by 8388216...c8850b5

hailwood commented 8 years ago

The other two cases aren't covered anyway heh.