search

igaster / laravel-theme

Theme support for Laravel
MIT License
516 stars 110 forks source link

Package is not working on Laravel 5.3 #43

Closed dcdiogo closed 7 years ago

dcdiogo commented 7 years ago

Dear,

When I tried to use this package on Laravel 5.3, the command php artisan optimize fails with the error: Symfony\Component\Debug\Exception\FatalThrowableError: Call to undefined method Illuminate\View\FileViewFinder::setPaths() On Laravel 5.2 it works fine.

By the way, greate package! Very usefull!.

Regards, Diogo

igaster commented 7 years ago

This package uses themeViewFinder.php (which extends Illuminate\View\FileViewFinder). All setup takes place at the themeServiceProvider.php. So my guess is that either

a) you forgot to add the service provider & alias at your app/config/app.php file

or

b) sometimes the order that you put your service providers does matter! Try to place the themeServiceProvider lower (Certainly after all Illuminate/xxx service providers)

Jeroen-G commented 7 years ago

Or c) the function is no more.

igaster commented 7 years ago

It is actually defined here: themeViewFinder.php

Can you please verify that the latest version of the package has been installed? (v1.1.3)

Maybe an error on composer.json ?

Jeroen-G commented 7 years ago

Ah, I was looking for that function in FileViewFinder